fix: resolve default export consistently #444
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
force-pushed
the
fix/resolve-default-export-consistently
branch
from
2c78f99 to
dbebcbf
Compare
sapphi-red
force-pushed
the
fix/resolve-default-export-consistently
branch
from
dbebcbf to
2715652
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
requires rolldown/rolldown#6434
fixes #425
fixes #421 (fixes the inconsistency, the expected error happens)
playground/css-codesplit-cjs/__tests__/css-codesplit-cjs.spec.tsfailure: previously it happened to not includerequirein the output file, but now it includes it. so this is not a bug